-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate API code + bootstrap webserver + simplify launch #8
Conversation
} | ||
|
||
@Override | ||
public void deletePet(Long petId, String apiKey) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
task fatjar(type: Jar) { | ||
manifest { | ||
attributes 'Main-Class': 'io.dataline.playground.HelloWorld' | ||
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.4.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed if we are importing it as testImplementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not the same lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
late night double vision
@@ -3,13 +3,15 @@ FROM gradle:jdk14 AS build | |||
|
|||
COPY . /code | |||
WORKDIR /code | |||
RUN gradle fatjar --no-daemon | |||
RUN gradle distTar --no-daemon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any particular reason to use tar vs jar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to follow the gradle way of distributing. I ran into a lot of problem with the server piece when I tried to create a fatjar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. the autogenerated controllers are nice.
…-dbt Filter out `None` items
No description provided.